Fix check for lint 30.4.0 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I run this lint check using AGP 7.4.0-rc01, I see the following output in the lint report: Unexpected failure during lint analysis of EditTextExtensions.kt (this is a bug in lint or one of the libraries it depends on)

Message: class com.youneedabudget.lintchecks.SerializableObjectMissingReadResolveDetector$createUastHandler$1 tried to access protected method 'org.jetbrains.kotlin.psi.KtClassOrObject org.jetbrains.uast.kotlin.KotlinUClass.getKtClass() The problem appears to be the use of KotlinUClass::ktClass. The same error appears for a check packaged in androidx.fragment (https://issuetracker.google.com/issues/237567009), which was fixed here: androidx/androidx@528b64f This commit ports the same fix to SerializableObjectMissingReadResolveDetector, as best as I could tell. (The tests all still passed for me!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run this lint check using AGP 7.4.0-rc01 (i.e. lint 30.4.0), I see the following output in the lint report:
The problem appears to be the use of
KotlinUClass::ktClass.The same error appears for a check packaged in androidx.fragment (https://issuetracker.google.com/issues/237567009), which was fixed here: androidx/androidx@528b64f
This commit ports the same fix to
SerializableObjectMissingReadResolveDetector, as best as I could tell. (The tests all still passed for me!)I am not an AST-traversing expert, so feel free to fix/improve upon my code if desired!