Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature:Autograding] Add pdflatex image #54

Merged
merged 2 commits into from
Oct 14, 2024
Merged

[Feature:Autograding] Add pdflatex image #54

merged 2 commits into from
Oct 14, 2024

Conversation

lavalleeale
Copy link
Contributor

@lavalleeale lavalleeale commented Sep 21, 2024

What is the current behavior?

Creates a docker file for pdflatex for
more_autograding_examples/test_notes_upload/

Closes Submitty/Submitty#10940

@lavalleeale lavalleeale self-assigned this Sep 21, 2024
Comment on lines 10 to 12
RUN mkdir -p /var/local/submitty/autograding_tmp

WORKDIR /var/local/submitty/autograding_tmp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary. The autograder will handle mounting when it runs testcases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path to this file should be .../pdflatex/{PDFLATEX_VERSION}/Dockerfile to allow users to specify the version in case of updates.

ARG DEBIAN_FRONTEND=noninteractive

RUN apt-get update
RUN apt-get install -qqy texlive-latex-base texlive-latex-recommended texlive-plain-generic texlive-latex-extra
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify the versions for these packages like you did python?

@lavalleeale lavalleeale requested a review from DarthNyan October 11, 2024 18:50
Copy link
Contributor

@DarthNyan DarthNyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bmcutler bmcutler merged commit ca9f553 into main Oct 14, 2024
4 checks passed
@bmcutler bmcutler deleted the pdflatex branch October 14, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Docker Image for running pdflatex
3 participants