Skip to content

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented May 29, 2019

#11 @0xdabbad00 You're right that editing all that .json would be tedious. This should turn those cells into proper links except these 4 .json lines' hyperlinks won't work yet because they contain multiple links:

{"id":8, "rule":"Mandatory tags", "type":"Tagging", "pacbot":"Application tags https://github.com/tmobile/pacbot/blob/master/jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/awsrules/ec2/CheckApplicationTagRule.java - Others https://github.com/tmobile/pacbot/blob/master/jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/awsrules/ec2/TaggingRule.java", "prowler":"", "security_monkey":"", "trusted_advisor":"", "config_rule": "", "cloudmapper":""},

{"id":12, "rule":"EC2 with specific ports public", "type":"Security", "pacbot":"9200 (ElasticSearch) https://github.com/tmobile/pacbot/blob/master/jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/awsrules/ec2/ElasticSearchInternalAccessRule.java - 3389 (RDP) https://github.com/tmobile/pacbot/blob/master/jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/awsrules/securitygroup/CheckForSecurityGroupWithRDPPortAnywhereAccess.java", "prowler":"https://github.com/toniblyx/prowler/blob/master/checks/check41 https://github.com/toniblyx/prowler/blob/master/checks/check42", "security_monkey":"", "trusted_advisor":"Y", "config_rule": "", "cloudmapper":""},

{"id":17, "rule":"Unused load balancer", "type":"Cost", "pacbot":"https://github.com/tmobile/pacbot/blob/master/jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/awsrules/elb/UnusedClassicElbRule.java https://github.com/tmobile/pacbot/blob/master/jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/awsrules/elb/UnusedApplicationElbRule.java", "prowler":"", "security_monkey":"", "trusted_advisor":"Y", "config_rule": "", "cloudmapper":""},

{"id":41, "rule":"Public S3", "type":"Security", "pacbot":"Read access https://github.com/tmobile/pacbot/blob/master/jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/awsrules/s3/S3GlobalReadAccessRule.java - Write access https://github.com/tmobile/pacbot/blob/master/jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/awsrules/s3/S3GlobalWriteAccessRule.java", "prowler":"https://github.com/toniblyx/prowler/blob/master/checks/check_extra73", "security_monkey":"https://github.com/Netflix/security_monkey/blob/develop/security_monkey/auditors/s3.py", "trusted_advisor":"Y", "config_rule": "https://docs.aws.amazon.com/config/latest/developerguide/s3-bucket-public-read-prohibited.html", "cloudmapper":"Y"},

@PatMyron
Copy link
Contributor Author

PatMyron commented May 29, 2019

@0xdabbad00 thoughts? Could also modify those non-conforming cells to point to one link or modify hyperlinkMutator() to add logic to handle multiple link cells

@PatMyron
Copy link
Contributor Author

PatMyron commented May 29, 2019

@0xdabbad00
Copy link
Contributor

Thanks for this and sorry for the delay. I'm looking into updating this spreadsheet with new data soon and thinking about how I can overcome some of the limitations of the current json tabulator concept. My biggest issue is the readability of the tables. Trying to view it on mobile, resizing the screen, just trying to read the cells, is all a bad experience with tabulator for how it exists now. I may be switching it back to a Google Sheets. Still not sure on the best path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants