fix(contracts): fix vault share price calculation — wrong denominator causes depositors to lose value#272
Open
wheval wants to merge 2 commits intoSuncrest-Labs:mainfrom
Open
fix(contracts): fix vault share price calculation — wrong denominator causes depositors to lose value#272wheval wants to merge 2 commits intoSuncrest-Labs:mainfrom
wheval wants to merge 2 commits intoSuncrest-Labs:mainfrom
Conversation
…ositors to lose value - Suncrest-Labs#156: fix(contracts): fix vault share price calculation — wrong denominator causes depositors to lose value Closes Suncrest-Labs#156
|
@wheval Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
wheval
changed the title
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary
total_assetsduring share minting.Why
The previous logic could misprice shares for new depositors after fee accrual and compute performance fee using mismatched units (
assets - shares), which could charge fee on principal.Test Plan
Closes #156
Closing
Closes #156