Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CoC #84

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Adding CoC #84

merged 1 commit into from
Oct 31, 2022

Conversation

vaishnav-mk
Copy link
Contributor

Added a link to svelte's CoC.
This should resolve #83

@netlify
Copy link

netlify bot commented Oct 31, 2022 •
edited
Loading

✅ Deploy Preview for sveltesirens ready!

Name Link
🔨 Latest commit 9f1b7e0
🔍 Latest deploy log https://app.netlify.com/sites/sveltesirens/deploys/635fb0259d8df500084c77b4
😎 Deploy Preview https://deploy-preview-84--sveltesirens.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghostdevv ghostdevv added the enhancement New feature or request label Oct 31, 2022
@spences10
Copy link
Collaborator

Thaks for the contribution @vaishnav-mk 👍

LGTM 😊

This shouldn't close #84 however.

There's a LICENCE and CONTRIBUTING.md that I feel should be added at the bare minimum before that can be closed, what are your thoughts on this @ghostdevv and @brittneypostma??

@ghostdevv
Copy link
Member

I'll sort the LICENSE out in a separate PR, I can't believe we don't have one! 😱 Re: CONTRIBUTING.md I don't mind whether we have one or not, feel free to open a issue for that (we can do that in another PR if you get around to making an issue)

@spences10
Copy link
Collaborator

Yeah, sure. I think the whole reason I brought this up was that there was a bit of confusion with an initial PR from @vaishnav-mk where a CONTRIBUTING.md could have helped clear up any uncertainty around the contribution that was made.

@ghostdevv
Copy link
Member

ghostdevv commented Oct 31, 2022 •
edited
Loading

Oki we can definitely add that then, I see you mentioned it in your issue (#83) I missed that 😅 - lets do it in another PR! Happy for anyone to take that PR otherwise I will get to it end of this week

Going to merge this one 🙏

@ghostdevv ghostdevv merged commit 9e991fd into Svelte-Sirens:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdevv ghostdevv ghostdevv approved these changes

@spences10 spences10 spences10 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update/add Community Standards
3 participants
@vaishnav-mk @spences10 @ghostdevv