Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name param #811

Closed
wants to merge 1 commit into from
Closed

feat: add name param #811

wants to merge 1 commit into from

Conversation

Zeyi-Lin
Copy link
Member

@Zeyi-Lin Zeyi-Lin commented Feb 4, 2025

Description

This pull request introduces the name parameter to the SwanLabRun initialization process in multiple files. The changes ensure that if both experiment_name and name are provided, a warning is issued, and if experiment_name is not provided, name is used as the default.

Enhancements to initialization process:

Closes: #809

@Zeyi-Lin Zeyi-Lin requested a review from SAKURA-CAT February 4, 2025 09:41
@Zeyi-Lin Zeyi-Lin self-assigned this Feb 4, 2025
@Zeyi-Lin Zeyi-Lin added 📚 documentation Improvements or additions to documentation 💪 enhancement New feature or request and removed 📚 documentation Improvements or additions to documentation labels Feb 4, 2025
@SAKURA-CAT
Copy link
Contributor

SAKURA-CAT commented Feb 5, 2025

适配的话,应该只把更改收拢到init这个函数里 新开一个分支改吧,重新改一下

@SAKURA-CAT SAKURA-CAT closed this Feb 5, 2025
@SAKURA-CAT SAKURA-CAT deleted the feat-name branch February 5, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADVICE] 用name参数等价experiment_name参数
2 participants