-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support importing json modules #336
Conversation
This is so strange that the CI test has been returning inconsistent results for |
The testsuite runs twice, once with the "latest" (aka the declared dependency version of the typescript compiler, which might need a bump in either case). That second run fails, whereas the first one succeeds. Some somewhere in between the TS compiler itself changed how it generates declarations for JSON. You can add the minimum TS version the test should run with in the |
Thanks for the detailed explanation ❤️ The impacted official version is
I'm not sure if it's meant to change the behavior of JSON modules, but since it doesn't impact actual usage, I'll let it be. 👌🏻 |
resolves #332
resolves #184
(Can also resolve some downstream issues: unjs/unbuild#430)