fix(web): unify Day and Week keyboard edit shortcuts - #2409
Merged
Conversation
Give Day the same Delete, Shift+day move, and draft arrow verbs as Week, share draft reposition logic, align shortcut help labels, and correct the sidebar toggle docs from [ to ]. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Also correct the sidebar focus helper comment to name the i shortcut. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Drop effect-synced refs in favor of render closures and draft store getState, navigate Day view after Shift+day nudges, and finish the remaining [ vs ] docs drift. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ac321167-006a-4e06-895f-35fc1b6932fb) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unifies the Day/Week keyboard edit contract so power users learn one map:
Delete,Shift+ArrowLeft/Right(move event ±1 day),Shift+ArrowUp/Down(15-min nudge), and arrow keys to reposition an open draftrepositionDraftByKeyboardutil used by Day and Week], not[Test plan
Delete— event deletes with undo toastShift+ArrowRightmoves a focused timed event to the next dayC, then arrow keys — draft moves; Left/Right also changes the day?and confirm Day/Week Edit sections match]to toggle sidebar (not[)