fix(web): never let the calendar be silently wrong - #2410
Merged
Conversation
Keep the event form open with field errors on invalid saves, roll back lone failed optimistic mutations (with toast), show a grid retry state on fetch errors, and refetch on SSE reopen and window focus. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Restore only the failed write key when other mutations are in flight, and always refetch event queries on window focus despite staleTime. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Avoid series fan-out and concurrent delete surgical restores that could clobber other optimistic writes; preserve demoEventIds on restore. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_4bc11f06-2301-450f-9610-b0916977d056) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three failure paths were silent; this wires existing query/mutation/SSE states into UI the app already knows how to show.
useSaveEventFormkeeps the form open and returnsfieldErrors; the event form renders them instead of discarding the draft.reportError), and still invalidate on settle. Concurrent writes are left alone so a newer optimistic edit is not clobbered.isError+refetch.openreconnect notifiesonStreamReopen→ invalidate events/calendars; event queries alsorefetchOnWindowFocus: true.Test plan
bun test:web --focused suites for save form, mutations, EventGrid, SSE connection/provider, SidebarEventDetails