refactor(web): extract draft resize transition - #2545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves draft-resize date math and edge-flip behavior out of
useDraftActionsinto a pure transition helper.Simplicity
The hook now owns gesture wiring and state effects; the 160-line date transition is isolated, direct to test, and reusable without React.
Automated validation
Added focused coverage for ordinary timed resize, both edge crossover directions, all-day resize, and cross-day rejection.
Independent review
Fresh review found missing all-day/reverse-flip regression coverage; those tests were added. No behavioral defects were confirmed.
Test plan
bun run test:web -- packages/web/src/views/Week/components/Draft/hooks/actions/draft-resize.util.test.ts packages/web/src/views/Week/components/Draft/hooks/actions/useDraftActions.test.tsbun run type-checkbun run lintbun run knip