Skip to content

fix(web): stabilize up next card - #2547

Merged
tyler-dane merged 2 commits into
mainfrom
fix/stable-up-next-slot
Aug 2, 2026
Merged

fix(web): stabilize up next card#2547
tyler-dane merged 2 commits into
mainfrom
fix/stable-up-next-slot

Conversation

@tyler-dane

Copy link
Copy Markdown
Contributor

Summary

  • keep the Up next card mounted when no visible future event remains, showing a quiet All clear state
  • give both card states the same minimum height so calendar toggles do not shift
  • cover hiding the only upcoming event calendar

Validation

  • bun test:web packages/web/src/components/Sidebar/UpNextCard/UpNextCard.test.tsx
  • bun run type-check
  • bun run lint
  • bun test:web (1,549 passing)
  • bun test:a11y
  • manual browser pass at http://localhost:9092/day/2026-08-01: created an upcoming event, hid its calendar, verified All clear rendered in place, the calendar row retained focus and position, and browser console had no warnings/errors.

Review

  • Simplification considered: no extraction or new state needed; the button and passive state intentionally have distinct semantics while sharing the fixed height.
  • Independent review: no actionable findings.

@tyler-dane
tyler-dane merged commit a7be59d into main Aug 2, 2026
20 checks passed
@tyler-dane
tyler-dane deleted the fix/stable-up-next-slot branch August 2, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant