Liquid -> Molten Renaming #580
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
this will likely void all liquids |
Contributor
Author
Yes that as well. Any fluid that is replaced will get vaporized. |
Member
|
dont merge this PR until 0.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new FluidStorageKey called Molten and a method for removing FluidStorageKeys from a material. Loops through all base GT materials that have a Dust + Fluid Property (so not solutions) and replaces the Liquid FluidStorageKey with Molten.
Don't merge without making an associated PR for the Supersymmetry modpack as this breaks all GroovyScript recipes that use the replaced fluids. It also appears to mess with the fluid's temperature for some reason? As a heads up I'm not a programmer by trade so if this code is suboptimal don't be shocked.