Antidote comparator #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: (69 commits) add 2.0.27 info revert leveldb version to blank before merge to develop branch address code review issues. revert worker thread default to 71 due to fact some customers have static advanced.conf files that do NOT set thread count. so their production environment would drop from 71 threads to 7 ... oops. adjust code to use 7 worker threads in non-production modes and/or developer mode. 71 threads will still be assigned by cuttlefish defaults for production. update test for default compression format to lz4. 2.0 branch not backported to develop remove double delete at line 148 by using RefDecNoDelete() instead of RefDec(). Use accessors instead direct variable access to enable memory fencing move m_CloseRequest to protected, forcing code to use accessors ... which now provides memory fencing address Issue 212, cleanup unused writebatch upon error. Switch access to m_CloseRequested to functions instead of direct access. Allows easy memory fencing. branch specific change disable time conversion in debug routine currently not used. update release info for 2.0.25 make lz4 the default compression instead of snappy Adjust the disabling of expiry_minutes to use unlimited keyword. revert to expiry module per vnode, allows multibackend differences update expiry cuttlefish params to match notes from cv create compression multi_backend test remove _Default case in compression translation block Adjusted open_options type definition to include proper type for compression tag. update -type and -spec for compression ...
* develop: (69 commits) add 2.0.27 info revert leveldb version to blank before merge to develop branch address code review issues. revert worker thread default to 71 due to fact some customers have static advanced.conf files that do NOT set thread count. so their production environment would drop from 71 threads to 7 ... oops. adjust code to use 7 worker threads in non-production modes and/or developer mode. 71 threads will still be assigned by cuttlefish defaults for production. update test for default compression format to lz4. 2.0 branch not backported to develop remove double delete at line 148 by using RefDecNoDelete() instead of RefDec(). Use accessors instead direct variable access to enable memory fencing move m_CloseRequest to protected, forcing code to use accessors ... which now provides memory fencing address Issue 212, cleanup unused writebatch upon error. Switch access to m_CloseRequested to functions instead of direct access. Allows easy memory fencing. branch specific change disable time conversion in debug routine currently not used. update release info for 2.0.25 make lz4 the default compression instead of snappy Adjust the disabling of expiry_minutes to use unlimited keyword. revert to expiry module per vnode, allows multibackend differences update expiry cuttlefish params to match notes from cv create compression multi_backend test remove _Default case in compression translation block Adjusted open_options type definition to include proper type for compression tag. update -type and -spec for compression ...
…veldb into antidote_comparator * 'antidote_comparator' of https://github.com/SyncFree/eleveldb:
* develop: Make multi_backend compression settings commented update BASHO_RELEASES change default compression expectation in basic_schema_test add description to compression algorithms snappy as default if nothing in riak.conf, default riak.conf sets lz4
|
I'm closing this PR, because it's replaced with #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new logging and caching module for antidote, will use eleveldb as one of its possible backends. In order to use eleveldb, we needed to code a new comparator, so keys get sorted as we want.
Keys sent to eleveldb are of type {Key, VC, op|snap}, where Key is the same key used in Antidote, and VC, is the VC of the operation/snapshot. They will get sorted first by key, and afterwords by the VC, putting the most recent VC first.
As Erlang serialises objects sent to eleveldb, according http://erlang.org/doc/apps/erts/erl_ext_dist.html, so what we do is check those code to compare keys.