947756: Need to remove the browser scroller for organization and myteam grid module #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmfarook7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
Need to remove the browser scroller for organization and myteam grid
Root cause
To improving the application ui for user friendly.
Reason for not identifying earlier
Find how it was missed in our earlier testing and development by analyzing the below checklist. This will help prevent similar mistakes in the future.
Guidelines/documents are not followed
Common guidelines / Core team guideline
Specification document
Requirement document
Guidelines/documents are not given
Common guidelines / Core team guideline
Specification document
Requirement document
Reason:
Guidelines/documents are not given - Requirement document
Action taken:
NA.
Related areas:
NA
Is it a breaking issue?
No
Solution description
Fixed the issue by setting the grid parent element as 100vh so that the browser scroller not came.
Output screenshots
Before
After
Areas affected and ensured
NA
Ensured the following cases:
Additional checklist
This may vary for different teams or products. Check with your scrum masters.
Did you run the automation against your fix? - Yes
Is there any API name change? - No
Is there any existing behavior change of other features due to this code change? - No
Does your new code introduce new warnings or binding errors? - No
Does your code pass all FxCop and StyleCop rules? a- No
Did you record this case in the unit test or UI test? - No