-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sip 366 implementation #2145
Open
leomassazza
wants to merge
59
commits into
main
Choose a base branch
from
SIP-366-implementation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,966
−384
Open
Sip 366 implementation #2145
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
2209136
wip sip366
leomassazza 45dfd41
wip 366
leomassazza cebc9c4
wip 366 start fixing tests
leomassazza f41d109
fix, wrong params for pair
leomassazza e3ab470
wip: add per collateral accounting
leomassazza 18de031
Test MarketManagerModule
leomassazza de561f0
Fix LiquidationModule test
leomassazza 1f49264
wip: fix tests
leomassazza 5a28067
checkpoint: fixing vault module test (wip)
leomassazza 13a5120
checkpoint: use delta for intent declarations
leomassazza b2cb01c
checkpoint: added some events
leomassazza 7280c58
Link to liquidation
leomassazza 64030e3
checkpoint: more tests fixed and bugs smashed
leomassazza 3f68d81
Fix tests
leomassazza c60b1c4
fix other project tests
leomassazza 6ae5345
fix another tests on bfp
leomassazza 8289f11
Only owner can delete all intents
leomassazza c6b5332
Make window time flexible with configuration changes
leomassazza 55cf924
wip: timing tests
leomassazza 383d27e
test edge cases
leomassazza 18a4308
Reduce AccountDelegationIntents footprint
leomassazza a47d06c
Cleanup and comments
leomassazza 12db077
update storage.dump
leomassazza 1027f7f
add skipped test - multiple markets with diff timing
leomassazza 3a4ac69
deps fix
leomassazza ed9d256
undo deps fix
leomassazza fc9cf62
Merge branch 'SIP-366-implementation' of https://github.com/Synthetix…
leomassazza f0531e2
fix deps
leomassazza d03d3ca
typos + remove account owner check on delete expired intents
leomassazza 0cf5549
PR review fixes (partial)
leomassazza 6c54a5d
fix: ensure intentId to process is still valid for the account (not r…
leomassazza 3c9f5be
fix pair using wrong key
leomassazza 50b6b61
fix tests
leomassazza f62dad5
propagate storage change
leomassazza 901f542
rename function (wip)
leomassazza 30953ee
add two new views
leomassazza 05cd81f
some fixes
leomassazza 2e5ddcd
add views test + small fix
leomassazza 9e836d5
PR Fixes -> SIP 366 (#2171)
leomassazza cb02ac7
Merge branch 'main' into SIP-366-implementation
leomassazza 4061dec
fix bfp tests
leomassazza f9ba8da
more fixes on bfp (roll back changes)
leomassazza cc0bd12
add missing empty line
leomassazza 62de774
add more info to view
leomassazza 9a44955
fix wrong sign + a small refactor
leomassazza 6272a49
fix test
leomassazza ac3ad55
rename FFs
leomassazza c11d354
fix tests
leomassazza c4fa5d3
Merge branch 'main' into SIP-366-implementation
leomassazza 0a2d08e
push storage dump
leomassazza b190bfc
Merge branch 'main' into SIP-366-implementation
leomassazza dde2c7d
Merge branch 'main' into SIP-366-implementation
leomassazza 4ff64db
Reduce delegationIntent footprint
leomassazza cd8a7f9
fix missing references to intent.id
leomassazza eb05eba
Merge branch 'main' into SIP-366-implementation
leomassazza 1f46654
Merge branch 'main' into SIP-366-implementation
leomassazza f960f81
fix test
leomassazza 712921c
Merge branch 'main' into SIP-366-implementation
leomassazza dcb9ea4
Merge branch 'main' into SIP-366-implementation
leomassazza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
wip: add per collateral accounting
- Loading branch information
commit e3ab470f4684c4d3597fd08a3241ed8a47bfaae0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we can avoid storing this and only track it off-chain, save about 2-3 storage slots!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this one is possible tho