Skip to content

[cmake] Fix coverage#46

Open
hiergaut wants to merge 19 commits intomainfrom
fixCoverage
Open

[cmake] Fix coverage#46
hiergaut wants to merge 19 commits intomainfrom
fixCoverage

Conversation

@hiergaut
Copy link
Contributor

@hiergaut hiergaut commented Apr 22, 2024

Pull Request Desription

Check if you branch history is PR compatible

  • Your branch need to be up to date with origin/main
  • Update your git repository git fetch origin if origin is this remote
  • Check format style with the script provided in scripts/source-format-all.sh
  • You must use clang-format style (github CI version is 11)
  • Your proposal must include a commit where the file CHANGELOG is updated (add a line describing the proposed change + PR id, see file for examples). If your contribution is significant, you can also ask to be added to the contributor list in the discussion.
    These checks are enforced by github workflow actions
    Please refer to the corresponding log in case of failure

UPDATE the form below to describe your PR

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines (see CONTRIBUTING)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.

  • What kind of change does this PR introduce?

    • bug fix
    • feature
    • docs update
    • other:
  • What is the current behavior? (You can also link to an open issue here)
    No check of decline coverage of tests performed.

  • What is the new behavior (if this is a feature change)?
    Check decline (compare to stats on main branch) for each branch.
    Save performance tests stats only for main branch.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    If you add code or new file, be aware to add tests for features you suggest.

  • Other information:

@hiergaut hiergaut self-assigned this Apr 22, 2024
@hiergaut hiergaut marked this pull request as draft April 22, 2024 16:30
@hiergaut hiergaut force-pushed the fixCoverage branch 3 times, most recently from b5453f8 to f7bf5a9 Compare May 1, 2024 08:47
@hiergaut hiergaut marked this pull request as ready for review May 1, 2024 08:47
@hiergaut
Copy link
Contributor Author

hiergaut commented May 1, 2024

Ready for review.

@hiergaut hiergaut marked this pull request as draft May 1, 2024 08:56
message("name :${name}")
message(FATAL_ERROR "test-${parentMacro}${name}.cpp not found in tests directory")
endif()
# if(NOT EXISTS "${PROJECT_SOURCE_DIR}/tests/${parentName}/test-${parentMacro}${name}.cpp")
Copy link
Contributor Author

@hiergaut hiergaut May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All source (cpp) file have to be a corresponding test. I'll do this in the future. Issue #51 reported.

@hiergaut hiergaut marked this pull request as ready for review May 1, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant