Open
Conversation
b5453f8 to
f7bf5a9
Compare
Contributor
Author
|
Ready for review. |
hiergaut
commented
May 1, 2024
| message("name :${name}") | ||
| message(FATAL_ERROR "test-${parentMacro}${name}.cpp not found in tests directory") | ||
| endif() | ||
| # if(NOT EXISTS "${PROJECT_SOURCE_DIR}/tests/${parentName}/test-${parentMacro}${name}.cpp") |
Contributor
Author
There was a problem hiding this comment.
All source (cpp) file have to be a corresponding test. I'll do this in the future. Issue #51 reported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Desription
Check if you branch history is PR compatible
git fetch originif origin is this remotescripts/source-format-all.shThese checks are enforced by github workflow actions
Please refer to the corresponding log in case of failure
UPDATE the form below to describe your PR
Please check if the PR fulfills these requirements
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
No check of decline coverage of tests performed.
What is the new behavior (if this is a feature change)?
Check decline (compare to stats on main branch) for each branch.
Save performance tests stats only for main branch.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
If you add code or new file, be aware to add tests for features you suggest.
Other information: