Merged
Conversation
Closed
📝 WalkthroughWalkthrough챌린지 프롬프트 템플릿을 상세화하고 OpenAI 기본 모델을 변경했습니다. Java 프롬프트 파일은 7일 챌린지 지향의 엄격한 JSON 출력 템플릿과 내부 검증 규칙으로 대체되었고, 설정 파일에서 기본 모델을 Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In
`@src/main/java/com/sopt/cherrish/domain/challenge/recommendation/infrastructure/prompt/ChallengePromptTemplate.java`:
- Around line 42-45: The prompt in ChallengePromptTemplate currently forbids the
standalone token "주", which overly blocks valid words (e.g., 주름, 주기); update the
forbidden-frequency rules to use concrete patterns instead of the single
character: replace "주" with explicit patterns like "주 1회", "주간", or
numeric/phrasing patterns (e.g., "주\\s*\\d+회", "주간") or regex equivalents so
only intended weekly-frequency phrases are matched; edit the frequency list in
ChallengePromptTemplate (the 1) 빈도 entry) to use those specific patterns/regexes
and ensure other frequency tokens (매일, 일일, N회/N번, 항상, 매번) remain unchanged.
- Around line 49-51: ChallengePromptTemplate에 포함된 JSON 예시에서 중괄호가 이중으로 들어가 JSON
파서가 실패할 수 있으니 템플릿 내 해당 JSON 블록(현재 "{{\n \"routines\": [...] \n}}" 형태)을 단일 중괄호로
바꿔 JSON을 유효하게 만드세요; ChallengePromptTemplate 클래스 내부의 템플릿 문자열 상수나 메서드(예: prompt
템플릿을 반환하는 변수/메서드)를 찾아 "{{"와 "}}"를 각각 "{"와 "}"로 수정하면 됩니다.
- Around line 18-40: The examples in ChallengePromptTemplate (class
ChallengePromptTemplate) contradict the forbidden/format rules: remove or
replace any forbidden items (e.g., "샤워", "PDRN", "괄사", "닦토", English/외래어 like
"폰") and non-standard terms with compliant Korean equivalents (e.g., "샤워 후" →
remove or replace with allowed everyday action, "PDRN 마스크팩" → "보습 마스크팩", "괄사" →
"페이스 마사지", "폰" → "휴대폰"), ensure each example routine is an action-oriented
Korean sentence ≤20 characters and denotes a daily action (no "주 N회"), and
update all category examples in ChallengePromptTemplate.java to follow these
constraints so examples no longer conflict with the "[절대 금지]" and "[작성 규칙]"
sections.
.../cherrish/domain/challenge/recommendation/infrastructure/prompt/ChallengePromptTemplate.java
Outdated
Show resolved
Hide resolved
.../cherrish/domain/challenge/recommendation/infrastructure/prompt/ChallengePromptTemplate.java
Show resolved
Hide resolved
.../cherrish/domain/challenge/recommendation/infrastructure/prompt/ChallengePromptTemplate.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🛠 Related issue 🛠
✏️ Work Description ✏️
📸 Screenshot 📸
😅 Uncompleted Tasks 😅
📢 To Reviewers 📢