Conversation
📝 WalkthroughSummary by CodeRabbit릴리스 노트
Walkthroughnotice-detail-layout 컴포넌트의 contents 스타일 padding 값을 단일값( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/compositions/src/notice-detail-layout/notice-detail-layout.css.ts`:
- Line 38: Extract the magic "13.5rem" padding value into a named constant and
use that constant in the padding declaration to improve maintainability; for
example, add a constant (e.g., BOTTOM_GRADIENT_PADDING or NOTICE_FOOTER_PADDING)
near the top of the file and replace the hard-coded value in the padding: '2rem
2rem 13.5rem' expression used in the notice-detail-layout styles so future
changes to the gradient/button area height only require updating the constant.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/compositions/src/notice-detail-layout/notice-detail-layout.css.ts
packages/compositions/src/notice-detail-layout/notice-detail-layout.css.ts
Show resolved
Hide resolved
Sohyunnnn
left a comment
There was a problem hiding this comment.
수고하셨습니다 👍
하단에 CTA 버튼이 있고 스크롤의 여지가 있는 페이지에 대해 전체적으로 수정 가능할 지 문의드립니다!
ex) 주최자: 홈, 공연 등록 수정, 주최 공지, 공지 업로드 등
eunkr82
left a comment
There was a problem hiding this comment.
깔끔하게 해결해 주신 것 같아요 ㅎㅎ 고생하셨습니다! 🎉🎉
📌 Summary
📚 Tasks
🔍 Describe
그라데이션 영역과 본문 겹침 이슈 해결
기존에는 하단 고정 버튼 영역 상단의 그라데이션 UI로 인해 본문 마지막 텍스트가 흐릿하게 보이는 문제가 있었어요.
하단 버튼 영역과 그라데이션 UI는 유지하고 본문 콘텐츠 영역에 하단 패딩을 추가해 마지막 텍스트가 해당 영역과 겹치지 않도록 개선했어요.
👀 To Reviewer
📸 Screenshot