feat: abstract oobi manager and add postgres backend#77
Closed
zdravko61 wants to merge 11 commits intoTHCLab:masterfrom
Closed
feat: abstract oobi manager and add postgres backend#77zdravko61 wants to merge 11 commits intoTHCLab:masterfrom
zdravko61 wants to merge 11 commits intoTHCLab:masterfrom
Conversation
…tecture Gate redb behind `storage-redb` feature flag (default ON) in keri-core and teliox so the core protocol logic can compile and run without redb. This enables future alternative storage backends (e.g., DynamoDB for serverless). Key changes: - Split EventStorage constructors: generic `new()` (no mailbox) vs `new_redb()` (RedbDatabase with mailbox) vs `new_with_mailbox()` (inject) - Make mailbox_data an Option<MailboxData> to support non-redb backends - Remove Any bound from EventValidator - Gate TelLogDatabase, teliox EscrowDatabase, and escrow module behind storage-redb feature - Genericize teliox escrow structs over K: EventDatabase for KEL storage - Add in-memory MemoryDatabase implementing all database traits for validation and testing - Move rkyv_adapter to database::rkyv_adapter (not under database::redb) Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Introduce `storage-postgres` feature and dependencies - Implement PostgresDatabase, log, escrow, and KSN log modules - Add SQL migrations for all KERI tables - Integrate with existing database traits and event flows Signed-off-by: Zdravko Iliev <[email protected]>
Signed-off-by: Zdravko Iliev <[email protected]>
Signed-off-by: Zdravko Iliev <[email protected]>
Signed-off-by: Zdravko Iliev <[email protected]>
storage Signed-off-by: Zdravko Iliev <[email protected]>
Signed-off-by: Zdravko Iliev <[email protected]>
- Replace dual cfg-gated OobiManager struct definitions with a single generic struct and per-backend type aliases (RedbOobiManager, PostgresOobiManager) - Make process_reply and process_signed_oobi generic over OobiStorageBackend - Propagate CBOR deserialization errors instead of silently dropping corrupted rows - Replace unwrap() on serde_json/serde_cbor serialization with ? via new Cbor/Json variants on PostgresError Signed-off-by: Zdravko Iliev <[email protected]>
- Split EndRoleAdd and EndRoleCut into separate arms (was incorrectly
merged)
- Add TODO comment on EndRoleCut matching redb's pending delete
semantics
- Replace silent _ => {} catch-all with explicit Ksn => todo!()
- Add Cbor and Json error variants to PostgresError and propagate
serialization/deserialization errors instead of panicking or silently
dropping failures
Signed-off-by: Zdravko Iliev <[email protected]>
Contributor
|
merged via #81 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
OobiStorageBackendtrait, makingOobiManager<S>generic over storageChanges
PostgresOobiStorageimplementing the trait via sqlx (feature = "oobi-manager")RedbOobiStoragebehind#[cfg(feature = "storage-redb")]get_end_rolereturningSome([])instead ofNoneon empty resultsOobiManager::newResultwith?at all call sitesFrom<OobiError>conversions across controller, witness, watcher, and `keri_core::Error