Draft PR: add logger for igwn.gwalert topic; brings fastavro dependency #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a prototype. In production, Hermes is subscribing to the equivalent GCNClassicOverKafka topics. For more info/docs, see https://emfollow.docs.ligo.org/userguide/tutorial/receiving/scimma.html#receiving-and-parsing-notices and some public talk slides: https://dcc.ligo.org/LIGO-G2202193/public
|
This needs review; how does it relate to the tom_alertstreams module? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a prototype. In production, Hermes is subscribing to the equivalent GCNClassicOverKafka topics. For more info/docs, see https://emfollow.docs.ligo.org/userguide/tutorial/receiving/scimma.html#receiving-and-parsing-notices and some public talk slides:
https://dcc.ligo.org/LIGO-G2202193/public
I'm parking these commits here, but it's not clear to me that they need to be merged.