Paul/simplifies from stale hosted entities #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpignolet
approved these changes
Dec 1, 2025
PaulFarault
force-pushed
the
paul/simplifies-from_stale_hosted_entities
branch
from
c7b4bad to
1296060
Compare
Contributor
Author
|
Force pushed after rebase on master. Also updated a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes None
Replace #630
Additional comments
This pull request refactors how reconfiguration operations are determined and sorted for stale hosted entities, improving type safety and code clarity. The main changes include replacing string-based operation names with the
OperationNametype, moving logic for filtering and sorting operations into the main method, and changing to "private" the_node_to_operationmethod in the DAG class which is not use outside anymore.It will allow to easily add a
can_limitcheck to know if an operation can be limited to specific host during reconfigure.Agreements