Skip to content

feat: add support for protobuf 4 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kunlin596
Copy link
Collaborator

@kunlin596 kunlin596 commented Apr 18, 2025

Changes:

  1. Update github actions base image to 22.04 since github is retiring 20.04.
  2. Fix docker container build and test.
  3. Update grpc tools to support protobuf 4.X.X.

The published package for testing is located in https://test.pypi.org/project/dgp/.

@kunlin596 kunlin596 force-pushed the kun/feat/update-dependencies-and-project-configs branch 3 times, most recently from c07322a to 8633a0a Compare April 18, 2025 02:56
@kunlin596
Copy link
Collaborator Author

@chrisochoatri please help me review, thanks!

@kunlin596 kunlin596 marked this pull request as draft April 18, 2025 03:34
@kunlin596 kunlin596 force-pushed the kun/feat/update-dependencies-and-project-configs branch 2 times, most recently from 239641d to f8b4850 Compare April 18, 2025 07:00
@kunlin596 kunlin596 marked this pull request as ready for review April 18, 2025 07:25
@kunlin596 kunlin596 force-pushed the kun/feat/update-dependencies-and-project-configs branch 5 times, most recently from 962f62f to 185d556 Compare April 21, 2025 11:19
@kunlin596 kunlin596 changed the title feat: update all dependencies and project configs feat: project configs Apr 21, 2025
@kunlin596 kunlin596 force-pushed the kun/feat/update-dependencies-and-project-configs branch from 185d556 to 675e58f Compare April 21, 2025 11:25
@kunlin596 kunlin596 changed the title feat: project configs feat: update project configs Apr 21, 2025
@kunlin596 kunlin596 force-pushed the kun/feat/update-dependencies-and-project-configs branch 8 times, most recently from b8d4c01 to 016704e Compare April 23, 2025 06:46
@kunlin596 kunlin596 changed the title feat: update project configs feat: add support for protobuf 4, update packaging and CI Apr 23, 2025
@kunlin596 kunlin596 force-pushed the kun/feat/update-dependencies-and-project-configs branch 5 times, most recently from 3f3e18c to c3cad79 Compare April 23, 2025 09:08
@kunlin596 kunlin596 force-pushed the kun/feat/update-dependencies-and-project-configs branch 12 times, most recently from b8d2cc5 to e3d5893 Compare April 28, 2025 05:31
@kunlin596 kunlin596 changed the title feat: add support for protobuf 4, update packaging and CI feat: add support for protobuf 5 Apr 28, 2025
@kunlin596 kunlin596 force-pushed the kun/feat/update-dependencies-and-project-configs branch 4 times, most recently from d87d4c0 to 794f2b5 Compare April 28, 2025 06:37
@kunlin596 kunlin596 changed the title feat: add support for protobuf 5 feat: add support for protobuf 4 May 1, 2025
@kunlin596 kunlin596 force-pushed the kun/feat/update-dependencies-and-project-configs branch from 794f2b5 to bb8c74b Compare May 1, 2025 02:42
Changes:

  1. Update github actions base image to 22.04 since github is retiring 20.04.
  2. Fix docker container build and test.
  3. Update grpc tools to support protobuf 4.X.X.
  4. Remove pb2 files from git tracking.
  5. Bump DGP version to 2.0.0.
@kunlin596 kunlin596 force-pushed the kun/feat/update-dependencies-and-project-configs branch from bb8c74b to 2434272 Compare May 1, 2025 02:43
Copy link
Collaborator

@chrisochoatri chrisochoatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good addition. Thank you!
LGTM

@kunlin596 kunlin596 merged commit 3f1c3e5 into TRI-ML:master May 1, 2025
3 checks passed
@kunlin596 kunlin596 deleted the kun/feat/update-dependencies-and-project-configs branch May 1, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants