Skip to content

Update various generic communciation #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 3, 2025
Merged

Update various generic communciation #27

merged 6 commits into from
Apr 3, 2025

Conversation

Thoemi09
Copy link
Contributor

  • Add generic and specialized reduce_into, gather_into and scatter_into functions
    • Move has_env checks into specializations
  • Update MPI routine for ranges
    • Allow non-contiguous ranges whenever possible
    • Allow input and output ranges to be larger than necessary
    • Allow gather and scatter to be performed in place
  • Update tests

@Thoemi09 Thoemi09 mentioned this pull request Mar 25, 2025
Merged
Thoemi09 added 6 commits April 2, 2025 18:00
@Thoemi09
Update various broadcast routines
106c28d 
- Move has_env checks to specializations
- Allow non-contiguous ranges in broadcast_range
- Support ranges with sizes > INT_MAX
- Update tests
@Thoemi09
Update various reduce routines
c5b7d4f 
- Move has_env checks to specializations
- Add generic reduce_into + mpi_reduce_into specializations
- Remove mpi_reduce_in_place specializations
- Remove mpi_reduce_in_place_range
- Allow non-contiguous ranges in reduce_range
- Support ranges with sizes > INT_MAX
- Update tests
@Thoemi09
Update various scatter routines
d23c002 
- Move has_env checks to specializations
- Add generic scatter_into + mpi_scatter_into specializations
- Update tests
@Thoemi09
Update various gather routines
603bb6a 
- Move has_env checks to specializations
- Add generic gather_into + mpi_gather_into specializations
- Add mpi_gather for MPI types
- Restrict gather_range to contiguous ranges with MPI types
- Update tests
@Thoemi09
Remove lazy.hpp
59c4fe6
@Thoemi09
Some basic clean up and doc updates
a205305
Wentzell
Wentzell approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@Wentzell Wentzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Thoemi09 for this big improvement and for incorporating all suggested changes. This looks great now!

@Wentzell Wentzell merged commit b584c74 into TRIQS:unstable Apr 3, 2025
4 checks passed
@Thoemi09 Thoemi09 deleted the DEV_GENERIC_COMM branch April 3, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wentzell Wentzell Wentzell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thoemi09 @Wentzell