Pass attributes on splice through to generated parser #3
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed parser/serializer, and adds tac_opaque to opaque parsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the V2 tactics'
splice_attrsfunction to get any attributes applied to a spliced generated parser, and applies them to the generated parser itself.Separately, in the opaque case, the
tac_opaqueattribute is added, in addition to"opaque_to_smt", reducing the degree to which parsers/serializers can be unintentionally normalized in tactics proofs (e.g., as part of theassumptiontactic, which may try to normalize hypotheses in the context as part of its execution, potentially leading to slowdown and high memory usage for complex generated parsers).