Skip to content

Fix auth and package label copy #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Taleef7 merged 1 commit into from
Apr 8, 2026
Merged

Fix auth and package label copy #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/auth/sign-in/SignInForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export function SignInForm() {
Sign In
</h1>
<p className="mt-1 text-sm text-[#121212]/60">
Don;&apos;t have an account?{' '}
Don&apos;t have an account?{' '}
<Link
href="/auth/sign-up"
className="font-bold text-[#1040C0] underline underline-offset-2 hover:text-[#D02020]"
Expand Down Expand Up @@ -161,4 +161,4 @@ export function SignInForm() {
</div>
</>
)
}
}
2 changes: 1 addition & 1 deletion app/dashboard/requests/new/RequestForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ export default function RequestForm({ subjects, initialTimezone }: RequestFormPr
✓
</span>
)}
<span className="text-2xl font-black text-[#121212]">{value}</span>
<span className="text-2xl font-black text-[#121212]">{value} </span>
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace fix here relies on a trailing literal space inside the JSX ("{value} "). This is easy to miss in reviews and can be unintentionally removed by formatting edits. For consistency with the rest of the repo (and with app/page.tsx in this PR), consider inserting an explicit JSX space node between the two spans instead (e.g., {value} then {' '} then the "sessions/month" span).

Suggested change
<span className="text-2xl font-black text-[#121212]">{value} </span>
<span className="text-2xl font-black text-[#121212]">{value}</span>
{' '}

Copilot uses AI. Check for mistakes.
<span className="text-[11px] font-bold uppercase tracking-wide text-[#121212]">
sessions/month
</span>
Expand Down
1 change: 1 addition & 0 deletions app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,7 @@ export default async function LandingPage() {

<p className="text-5xl font-black leading-none">
{sessions}
{' '}
<span className="text-sm font-medium text-[#121212]/40 ml-1">sessions/month</span>
</p>
<p className="mt-1 text-xs font-black uppercase tracking-wider text-[#121212]/40">
Expand Down
6 changes: 6 additions & 0 deletions e2e/auth.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ import { test, expect } from "@playwright/test";
test.describe("Auth Pages", () => {
test("sign-in page renders form", async ({ page }) => {
await page.goto("/auth/sign-in");
await expect(
page.locator("p").filter({ hasText: "Don't have an account?" }),
).toBeVisible();
await expect(page.locator("p").filter({ hasText: "Don;'t" })).toHaveCount(
0,
);
await expect(page.getByLabel(/email/i)).toBeVisible();
await expect(page.getByLabel("Password")).toBeVisible();
await expect(
Expand Down
3 changes: 3 additions & 0 deletions e2e/landing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ test.describe("Landing Page", () => {
await expect(page.getByText(/8\s*sessions/i).first()).toBeVisible();
await expect(page.getByText(/12\s*sessions/i).first()).toBeVisible();
await expect(page.getByText(/20\s*sessions/i).first()).toBeVisible();
await expect(page.getByText(/8sessions\/month/i)).toHaveCount(0);
await expect(page.getByText(/12sessions\/month/i)).toHaveCount(0);
await expect(page.getByText(/20sessions\/month/i)).toHaveCount(0);
Comment on lines +19 to +21
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three negative assertions are nearly identical and could be made more maintainable by iterating over the package counts (8/12/20) in a small loop. That reduces repetition and makes it easier to update if tiers change.

Suggested change
await expect(page.getByText(/8sessions\/month/i)).toHaveCount(0);
await expect(page.getByText(/12sessions\/month/i)).toHaveCount(0);
await expect(page.getByText(/20sessions\/month/i)).toHaveCount(0);
for (const packageCount of [8, 12, 20]) {
await expect(
page.getByText(new RegExp(`${packageCount}sessions\\/month`, "i")),
).toHaveCount(0);
}

Copilot uses AI. Check for mistakes.
});

test("no admin link visible on public nav", async ({ page }) => {
Expand Down
Loading