feat: CreateStreamForm skeleton#782
Open
unajiogenyi05-hub wants to merge 1 commit into
Open
Conversation
- Add Skeleton component (src/components/Skeleton.tsx)
- Single themed shimmer block using --muted CSS design token
- aria-hidden; animate-pulse + motion-reduce:animate-none
- SkeletonContainer wrapper: role=status, aria-live=polite,
aria-busy=true, sr-only label for screen reader announcement
- Add CreateStreamForm (src/components/CreateStreamForm.tsx)
- isLoading prop: renders CreateStreamFormSkeleton when true
- Skeleton mirrors form layout to prevent layout shift
- Full field validation, aria-invalid, aria-describedby, role=alert
- Ctrl/Cmd+Enter submit shortcut; Escape cancel shortcut
- WCAG 2.1 AA: labels, required markers, focus-visible rings
- Light/dark theme via CSS design tokens (--border, --card, --muted)
- Add CreateStreamFormSkeleton.test.tsx: 44 tests all passing
- Skeleton and SkeletonContainer unit tests
- CreateStreamFormSkeleton: structure, no interactive controls, axe
- CreateStreamForm isLoading transitions; axe in all states
- Validation, keyboard shortcuts, successful submit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #
Type of Change
Pre-flight Checklist
All items must be checked before requesting review.
npm run lintpasses with no errorsnpm testpasses with no failuresnpm run buildcompletes successfullyTesting & Coverage
(run
npm test -- --coverageand check the per-file table)the shared utilities in
src/test-utils/a11y.tsxWhat was tested?
Accessibility & Security Notes
Accessibility
Security
closes #1043