feat: verify blake2b-hashed payload signatures (Ledger)#14
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
siws-demo | 1f5ea2a | Jul 06 2026, 08:16 AM |
0xKheops
force-pushed
the
fix/ledger-hashed-signatures
branch
from
July 6, 2026 08:11
3c13e90 to
5cb61a8
Compare
0xKheops
changed the title
0xKheops
force-pushed
the
fix/ledger-hashed-signatures
branch
from
July 6, 2026 08:14
5cb61a8 to
d7c0244
Compare
0xKheops
force-pushed
the
fix/ledger-hashed-signatures
branch
from
July 6, 2026 08:15
d7c0244 to
1f5ea2a
Compare
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ledger Polkadot Generic app signs
blake2b-256(<Bytes>message</Bytes>)for payloads over 256 bytes (Substrate convention) instead of the raw bytes, so SIWS verification always failed for Ledger accounts.verifySignaturenow also tries the blake2b-256 hash of the message and its<Bytes>-toggled variant when the payload exceeds 256 bytes. Includes a signature captured from a real device as test vector.