- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 537
 
fix(form-core): fix fields being stale on array changes #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 
           View your CI Pipeline Execution ↗ for commit 91ced86 
 ☁️ Nx Cloud last updated this comment at   | 
    
          Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #1729      +/-   ##
==========================================
+ Coverage   90.35%   90.61%   +0.26%     
==========================================
  Files          38       38              
  Lines        1752     1812      +60     
  Branches      444      466      +22     
==========================================
+ Hits         1583     1642      +59     
- Misses        149      151       +2     
+ Partials       20       19       -1     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
| 
           Notes to self: Swapping, deletion and basic reset seems to work. However, there's conflicts with the reset that need further investigating.  | 
    
…stack-form into undefined-default-value
          
 | 
    
…efined-default-value
| 
           
 
  | 
    
93e3caa    to
    60e4c68      
    Compare
  
    | 
           
 Todos: 
  | 
    
FieldApi.update| 
           Solid appears to be struggling with this implementation still. I'll look into what can be done to fix it.  | 
    
| 
           
  | 
    
| 
           Arrays look to be fixed, at least confirmed for React. However, it looks like   | 
    
Closes #1614
Closes #1561
Closes #1577
Closes #1289
Fixes:
field.handleChange(undefined)no longer sets the value to the default valueform.reset()and array methods no longer break controlled input when non-index keys are usedTodos: