Conversation
…ublic key verification Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Tanker187/firebase-admin-node/security/code-scanning/13
In general, to fix this issue you must not call
jwt.verifywith a falsy secret/key. Instead, either (a) provide a real cryptographic secret/public key that matches how the token was signed, or (b) if you are dealing with intentionally unsigned tokens (algorithmnone), avoidverifyand only usejwt.decodefor structural checks, understanding that no integrity is guaranteed.For this specific test, the goal is only to ensure that
createCustomTokenwith anEmulatedSignerproduces an unsigned token and that its header/payload are as expected. There is no need to invokejwt.verifywithalg: 'none'. We can safely remove that call and rely solely onjwt.decode(already used below) to validate the token structure and claims. This preserves existing test behavior while eliminating the insecure pattern.Concrete change in
test/unit/auth/token-generator.spec.ts:"Emulator"describeblock, in the test'should generate a valid unsigned token', delete the block that callsjwt.verify(token, undefined as any, { algorithms: ['none'] });and the preceding comment that refers to it.Suggested fixes powered by Copilot Autofix. Review carefully before merging.