Skip to content

fix: correct variable assignment for risk manager #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Laxmi884 wants to merge 1 commit into from
Closed

fix: correct variable assignment for risk manager #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tradingagents/agents/managers/risk_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def risk_manager_node(state) -> dict:
risk_debate_state = state["risk_debate_state"]
market_research_report = state["market_report"]
news_report = state["news_report"]
fundamentals_report = state["news_report"]
fundamentals_report = state["fundamentals_report"]
Copy link

@gemini-code-assist gemini-code-assist bot Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

A high-severity Prompt Injection vulnerability exists here: the risk_manager_node function constructs an LLM prompt by directly embedding unsanitized content from the state object, including reports like market_research_report and fundamentals_report. This allows an attacker to inject malicious instructions and manipulate trading decisions. While the change on line 14 fixes a bug, it is part of this vulnerable data flow. Additionally, the current state access using [] can lead to KeyError if keys are missing; consider using .get() for more robust state access.

sentiment_report = state["sentiment_report"]
trader_plan = state["investment_plan"]

Expand Down