Fix bind-param of displaced vectors #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the underlying vector is displaced on another array, and potentially with a fill pointer below its capacity, we need to do some pointer arithmetic. We use babel to extract the underlying simple array because it's already a transitive dependency via cffi.
vindvaki
commented
Jul 10, 2024
We can just put start 0 and end nil. The underlying library figures out the right values.
Author
|
Actually, I'm seeing some possible performance regressions locally with this patch. Need to investigate. |
Author
The performance impact was due to some other changes in my program, not this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the underlying vector is displaced on another array, and potentially with a fill pointer below its capacity, we need to do some pointer arithmetic. We use babel to extract the underlying simple array because it's already a transitive dependency via cffi.
Without this patch, I have to copy non-simple vectors before inserting, which is wasteful.