Conversation
1 task
sonms
approved these changes
Feb 3, 2026
Member
sonms
left a comment
sonms
left a comment
There was a problem hiding this comment.
굿굿입니다! 저는 근데 generator랑 benchmarks 는 디렉토리를 나눠서 분리하는게 좋다고 생각하는데 주완님 생각은 어떠신가용?
Comment on lines
+8
to
+9
| @Keep | ||
| @Serializable |
Member
Author
There was a problem hiding this comment.
이게 처음에 테스트를 돌려봤는데, 해당 model 에서만 직렬화 과정에서 오류가 난다고 계속 뜨더라구요 ㅜㅜ 난독화나 최적화 과정에서 누락될 가능성이 있다고해서 어노테이션 추가했습니답
baselineProfile/src/main/java/com/kiero/baselineprofile/StartupBenchmarks.kt
Outdated
Show resolved
Hide resolved
dmp100
approved these changes
Feb 3, 2026
Collaborator
dmp100
left a comment
dmp100
left a comment
There was a problem hiding this comment.
저도 새로 공부해봐야할게 생겼네용 간단하게 사용법정도 노션에 정리해주시면 더 좋을거같아요 !
| // Start default activity for your app | ||
| pressHome() | ||
| startActivityAndWait() | ||
|
|
Collaborator
There was a problem hiding this comment.
p3) 지금은 기본 앱 시작만 적용된거같은데, 어디까지 이거를 적용시키실 생각이신가요 ?
개인적으로는 GIF가 들어간 화면위주로 진행되어도 좋지않을까 생각합니다 !
Member
Author
There was a problem hiding this comment.
pr 에 올려놨듯이, 로그인 관련해서 좀 더 공부해보고 이 후 화면까지 적용해볼 예정입니다! 말씀대로 GIF나 화면 렌더링시 데이터가 많이 필요한 곳 위주로 테스트해볼 계획입니당
baselineProfile/src/main/java/com/kiero/baselineprofile/StartupBenchmarks.kt
Outdated
Show resolved
Hide resolved
seungjae708
approved these changes
Feb 3, 2026
Member
Author
경로 분리했습니다! 좋은 의견 감사합니당 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE
❗ WORK DESCRIPTION
📢 TO REVIEWERS
📸 SCREENSHOT