-
Notifications
You must be signed in to change notification settings - Fork 0
[refactor/#85] 부모 일정 뷰 수정 및 전체 구조, 화면 변경 #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e848b38
refactor/#85: parent/schedule 경로 변경
vvan2 5492a0b
refactor/#85: parent/mission 경로 변경
vvan2 0395390
refactor/#85: parent/mission 경로 변경
vvan2 b704031
refactor/#85: parent/alarm 경로 변경
vvan2 4af67d9
refactor/#85: parent/schedule 뷰 수정 및 네비게이션 변경
vvan2 1996e30
refactor/#85: parent 스프린트 추가 화면 세팅
vvan2 bff2476
refactor/#85: parent bottom bar 수정
vvan2 0936225
refactor/#85: parent navigation 수정
vvan2 79b6632
refactor/#85: preview theme 적용
vvan2 3a406d2
refactor/#85: 경로변경
vvan2 7c4aadc
refactor/#85:empty view 변경사항 적용
vvan2 e068000
refactor/#85: dummyfile 제거
vvan2 98fbdbb
refactor/#85: 앱 메인로고 변경
vvan2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
18 changes: 0 additions & 18 deletions
18
app/src/main/java/com/kiero/core/network/model/DummyBaseResponse.kt
This file was deleted.
Oops, something went wrong.
15 changes: 0 additions & 15 deletions
15
app/src/main/java/com/kiero/data/auth/remote/api/DummyService.kt
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
app/src/main/java/com/kiero/data/auth/remote/datasource/DummyDataSource.kt
This file was deleted.
Oops, something went wrong.
14 changes: 0 additions & 14 deletions
14
app/src/main/java/com/kiero/data/auth/remote/datasourceimpl/DummyDataSourceImpl.kt
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
app/src/main/java/com/kiero/data/auth/remote/dto/request/DummyRequestDto.kt
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
app/src/main/java/com/kiero/data/auth/remote/dto/response/DummyResponseDto.kt
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 parent의 route들에 어떤 것은 parent 가 붙고 어떤 것은 안 붙어져 있는 상태이고 kid 역시 그런데 이것을 동일하게 parent나 kid를 붙이도록 하는게 일관성이 있어 파악하기 쉬울까요? 아니면 괜찮을까요?
고민 중인데 여러분 생각은 어떠신가요?
@Team-Kiero/kiero-android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parent와 kid route 들 중에 중복되는 것들을 구분하기 위해 1차적으로 중복되는 것들에만 Parent 를 붙혔는데, 일관성 있게 처리하는게 좀 더 파악하기 쉬워보이긴 하네요!! 다른 분들 의견 들어보고 일치하면 route들 앞에 parent/kid 로 구분해 놓겠습니다! 감사합니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저두 일관성있는게 앞에 붙이는게 나중에 헷갈리지 않고 좋을 것 같다는 생각입니다!