[Refactor] 구글 소셜 로그인 기능 제거#208
Merged
Merged
Conversation
📝 WalkthroughWalkthrough구글 소셜 로그인 기능을 완전히 제거합니다. 컨트롤러 엔드포인트, 서비스 메서드, 토큰 생성 로직, 관련 DTO 및 설정 전체를 삭제하여 구글 OAuth 흐름을 비활성화합니다. Changes구글 소셜 로그인 기능 제거
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/java/com/proovy/domain/user/entity/OAuthProvider.java`:
- Around line 3-5: OAuthProvider enum removed the GOOGLE constant which will
cause IllegalArgumentException when JPA tries to load rows with
provider='GOOGLE' (OAuthProvider.valueOf("GOOGLE")), so either ensure DB is
brand-new or migrate/delete those records before deploy; alternatively add a
safe handling path by temporarily reintroducing a GOOGLE enum constant in
OAuthProvider or implementing a static from(String) method/AttributeConverter
that maps unknown values to a fallback (e.g., UNKNOWN) and update migration
scripts to convert or remove GOOGLE rows and include rollback/backup steps.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 96cd2ad7-000a-40ed-b38e-7d6b473bb08b
📒 Files selected for processing (11)
src/main/java/com/proovy/domain/auth/controller/AuthController.javasrc/main/java/com/proovy/domain/auth/dto/google/GoogleTokenResponse.javasrc/main/java/com/proovy/domain/auth/dto/google/GoogleUserResponse.javasrc/main/java/com/proovy/domain/auth/dto/request/GoogleLoginRequest.javasrc/main/java/com/proovy/domain/auth/dto/response/GoogleUserInfo.javasrc/main/java/com/proovy/domain/auth/dto/response/LoginResponse.javasrc/main/java/com/proovy/domain/auth/provider/GoogleOAuthClient.javasrc/main/java/com/proovy/domain/auth/service/AuthService.javasrc/main/java/com/proovy/domain/auth/service/JwtTokenProvider.javasrc/main/java/com/proovy/domain/user/entity/OAuthProvider.javasrc/main/resources/application.yaml
💤 Files with no reviewable changes (9)
- src/main/java/com/proovy/domain/auth/dto/response/GoogleUserInfo.java
- src/main/java/com/proovy/domain/auth/dto/google/GoogleUserResponse.java
- src/main/java/com/proovy/domain/auth/dto/request/GoogleLoginRequest.java
- src/main/java/com/proovy/domain/auth/dto/google/GoogleTokenResponse.java
- src/main/java/com/proovy/domain/auth/provider/GoogleOAuthClient.java
- src/main/resources/application.yaml
- src/main/java/com/proovy/domain/auth/service/AuthService.java
- src/main/java/com/proovy/domain/auth/service/JwtTokenProvider.java
- src/main/java/com/proovy/domain/auth/controller/AuthController.java
Collaborator
Author
꼼장어입니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
🏷️ PR 타입
📝 작업 내용
구글 소셜 로그인 기능 완전 제거
중복 계정 생성을 방지하기 위해 구글 OAuth 로그인 관련 코드를 모두 제거했습니다.
제거된 파일들
GoogleOAuthClient.java- 구글 OAuth 클라이언트GoogleTokenResponse.java- 구글 토큰 응답 DTOGoogleUserResponse.java- 구글 사용자 정보 응답 DTOGoogleLoginRequest.java- 구글 로그인 요청 DTOGoogleUserInfo.java- 구글 사용자 정보 DTO수정된 파일들
OAuthProvider.java- GOOGLE enum 제거AuthController.java-/api/auth/login/google엔드포인트 제거AuthService.java-googleLogin()메서드 및 GoogleOAuthClient 의존성 제거JwtTokenProvider.java- 구글용generateSignupToken()메서드 제거LoginResponse.java- 구글 관련 필드 및 정적 메서드 제거application.yaml- 구글 OAuth 설정 제거제거 이유
영향도
/api/auth/login/google엔드포인트 제거📸 스크린샷
./gradlew compileJava통과✅ 체크리스트
📎 기타 참고사항
GOOGLE_CLIENT_ID,GOOGLE_CLIENT_SECRET,GOOGLE_REDIRECT_URI)도 제거 예정Summary by CodeRabbit
Release Notes