[EDMT-437] 포트 Switch 단계에 nginx 컨테이너 실행 보장 로직 추가#68
Conversation
… selection in dev
…c target selection in prod
|
Caution Review failedThe pull request is closed. Walkthrough배포 워크플로우의 nginx 업스트림 전환 단계에 실행 가드가 추가되었고, 활성 앱(blue/green)에 따라 NEW_TARGET을 계산한 뒤 service-url.inc를 갱신하고 nginx 설정 테스트 및 리로드를 수행합니다. dev/prod CD 모두 nginx 컨테이너 미실행 시 docker-compose로 기동하도록 보강되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions (dev/prod CD)
participant SSH as Remote Host
participant NG as nginx Container
participant DC as docker-compose
GH->>SSH: 배포 단계 실행
SSH->>SSH: 활성 앱 확인 (blue/green) → NEW_TARGET 계산
SSH->>NG: 상태 확인 (실행 중?)
alt nginx 미실행
SSH->>DC: docker-compose up -d nginx
DC-->>SSH: nginx 기동
else nginx 실행 중
Note over SSH,NG: 그대로 진행
end
SSH->>NG: /etc/nginx/conf.d/service-url.inc 갱신
SSH->>NG: nginx -t (설정 테스트)
NG-->>SSH: 테스트 결과
SSH->>NG: nginx -s reload (리로드)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment |
📣 Jira Ticket
EDMT-437
👩💻 작업 내용
포트 Switch 단계에 nginx 컨테이너 실행 보장 로직 추가
Summary by CodeRabbit