fix: Handle the case of a corrupt JSON config#101
Merged
Conversation
RubenBroere
requested changes
Apr 4, 2025
RubenBroere
requested changes
Apr 4, 2025
RubenBroere
approved these changes
Apr 4, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
Fix the bug where a corrupt
config.jsonfile (filled with\0bytes, for example) would crash WheelWizard.How to Test:
Write a single
\0byte at the start of the JSON file and remove all other contents. Then open WheelWizard – it should not crash anymore but log the exception and the loaded config is empty. Entering the settings again and hitting save should overwrite the file in a way that the\0byte is gone.What Has Been Changed:
The initial setup of the application was rewritten to pass the service provider to the
LoadSettingsmethod (for logging purposes).Related Issue Link:
#100
Checklist before merging