Skip to content

fix/feat: Allow origional name on mod download - Rewrote scaling of popups - Made feedback textobx#104

Merged
DirkDoes merged 26 commits into
devfrom
fix/spelling-mistakes-+-mod-rename-bug
Apr 7, 2025
Merged

fix/feat: Allow origional name on mod download - Rewrote scaling of popups - Made feedback textobx#104
DirkDoes merged 26 commits into
devfrom
fix/spelling-mistakes-+-mod-rename-bug

Conversation

@DirkDoes
Copy link
Copy Markdown
Member

@DirkDoes DirkDoes commented Apr 4, 2025

Purpose of this PR:

This PR kind of got out of hand when fixing 1 bug.
So now it contains the following:

  1. Popups now have a different way on how to define their with and height which allows you to also say that their width and height wraps around the content.
  2. Added a FeedbackTextBox which is a behavior component. This is a textfield with some extra usefull stuff which, when provided an Error will turn red and also show the error message underneath.
  3. When downloading a mod, you where'nt able to use the name imidiatly suggested. Now you can.

BehaviorComponents is something new. Its just a bunch of components and functionality stuffed together in one component that we will most likely re-use in multiple places. If anyone has better name suggestion, go ahead and let them know

How to test:

  1. Run the application and go through a bunch of popups. they all should look the same.
  2. Go through the 3 different naming popup and type random stuff and see when it turns red
  3. download a mod and see that it allows you to use that name that it suggests (unless that name is already taken)

Related Issue Link:

#102

Checklist before merging

  • You have created relevant tests

RubenBroere
RubenBroere previously approved these changes Apr 4, 2025
@DirkDoes DirkDoes changed the title fix: Allow original mod name + spelling correcitons [WIP] fix: Allow original mod name + spelling correcitons Apr 4, 2025
@DirkDoes
Copy link
Copy Markdown
Member Author

DirkDoes commented Apr 4, 2025

aperently something is not right yet. Dont merge it. I will take a look at it later

@DirkDoes DirkDoes closed this Apr 4, 2025
@DirkDoes DirkDoes reopened this Apr 4, 2025
@DirkDoes DirkDoes marked this pull request as draft April 4, 2025 22:36
@DirkDoes DirkDoes changed the title [WIP] fix: Allow original mod name + spelling correcitons fix/feat: Allow origional name on mod download - Rewrote scaling of popups - Made feedback textobx Apr 6, 2025
@DirkDoes DirkDoes requested review from RubenBroere and patchzyy April 6, 2025 20:31
@DirkDoes DirkDoes marked this pull request as ready for review April 6, 2025 20:31
@DirkDoes
Copy link
Copy Markdown
Member Author

DirkDoes commented Apr 6, 2025

Wait with merging this PR. i wanna merge this after #98 has been merged

@matellush
Copy link
Copy Markdown
Collaborator

There is still a bug where a mod name that is too long crashes the renaming process, leading to the loss of the mod. The resulting path length would also have to be validated somehow to avoid this.

@matellush
Copy link
Copy Markdown
Collaborator

I believe the validation of the Mii names (their lengths) should also be looked at again since I believe names can be shorter as well.

@matellush
Copy link
Copy Markdown
Collaborator

I think CombineFilesIntoSingleModAsync in the ModManager could also use validation, right? That should be the mod import function – that name should also be validated.

@matellush
Copy link
Copy Markdown
Collaborator

It would also be nice if the mod installation name popup's cancel action would work without any error popup (like the rest).

Comment thread WheelWizard/Services/ModManager.cs Outdated
Comment thread WheelWizard/Services/ModManager.cs Outdated
Comment thread WheelWizard/Views/Popups/Generic/TextInputWindow.axaml.cs Outdated
RubenBroere
RubenBroere previously approved these changes Apr 7, 2025
@matellush
Copy link
Copy Markdown
Collaborator

Thank you, everything's resolved for me!

@DirkDoes DirkDoes merged commit 741a09e into dev Apr 7, 2025
3 checks passed
@DirkDoes DirkDoes deleted the fix/spelling-mistakes-+-mod-rename-bug branch April 7, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants