Skip to content

fix: Drop incorrect expression in Dolphin location validation#166

Merged
patchzyy merged 1 commit into
TeamWheelWizard:devfrom
matellush:fix/dolphin-location-correctness
Jun 4, 2025
Merged

fix: Drop incorrect expression in Dolphin location validation#166
patchzyy merged 1 commit into
TeamWheelWizard:devfrom
matellush:fix/dolphin-location-correctness

Conversation

@matellush

Copy link
Copy Markdown
Collaborator

This is a minor fix for correctness of the validation of Unix commands as the Dolphin location in Wheel Wizard. Since the setting is always interpreted as a shell command, it does not make sense to check for file existence. For example, in the case of a file path with a space and missing quotes around it, FileHelper.FileExists(pathOrCommand) would return true even if that path would fail when trying to launch Dolphin, since the shell would try to execute the command up until the first space, the rest being arguments.

Both relative paths (dot-relative) and absolute paths will continue to work and validation would still succeed with this change. Note that any executable paths with spaces need to be quoted (or escaped) (which the GUI will do automatically) on Linux or macOS, as one would do it in the shell.

@patchzyy patchzyy merged commit da19517 into TeamWheelWizard:dev Jun 4, 2025
1 check passed
@matellush matellush deleted the fix/dolphin-location-correctness branch June 4, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants