fix: Drop incorrect expression in Dolphin location validation#166
Merged
patchzyy merged 1 commit intoJun 4, 2025
Conversation
patchzyy
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor fix for correctness of the validation of Unix commands as the Dolphin location in Wheel Wizard. Since the setting is always interpreted as a shell command, it does not make sense to check for file existence. For example, in the case of a file path with a space and missing quotes around it,
FileHelper.FileExists(pathOrCommand)would returntrueeven if that path would fail when trying to launch Dolphin, since the shell would try to execute the command up until the first space, the rest being arguments.Both relative paths (dot-relative) and absolute paths will continue to work and validation would still succeed with this change. Note that any executable paths with spaces need to be quoted (or escaped) (which the GUI will do automatically) on Linux or macOS, as one would do it in the shell.