fix: initial RetroRewind installation crashes WheelWizard#177
Merged
Conversation
Creating the parent directory for the 'finalDestination' recursively to avoid a potential crash from Directory.Move
DirkDoes
previously approved these changes
Jun 29, 2025
Member
|
thanks for the fix! |
Contributor
Author
|
np! |
Member
|
also, @patchzyy , this seems to throw an error rather than returning a Operation result But i think we cant simply replace it with returning an operation result due to there being a final clause. Not sure what your thought on this is. I think we can just let it slide for now and fix that in a seperate PR since that is not related to this fix. |
fixed by also moving over the riivolution/ folder contents. skips existing files. RetroRewind6.xml is deleted before copying to replace when updating.
Contributor
Author
|
Updated to also fix the missing RetroRewind6.xml in the riivolution folder |
DirkDoes
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
this PR fixes the crash when freshly installing RR.
How to Test:
RiivolutionorWheelWizarddirectory of the<UserFolderPath>/Load/Riivolution/WheelWizard/path.What Has Been Changed:
inserted a few lines in
WheelWizard/Features/CustomDistributions/RetroRewind.csbefore copying the extracted RR files to create the parent directory if necessary.Related Issue Link:
#168
Checklist before merging