Skip to content

fix: Also try to fix RR.json portal access if folder was changed#250

Merged
patchzyy merged 1 commit into
devfrom
fix/dolphin-rr-json-access
Apr 8, 2026
Merged

fix: Also try to fix RR.json portal access if folder was changed#250
patchzyy merged 1 commit into
devfrom
fix/dolphin-rr-json-access

Conversation

@matellush
Copy link
Copy Markdown
Collaborator

@matellush matellush commented Apr 4, 2026

This should help resolve the issue where a changed Wheel Wizard config folder would lead to the game not launching on Linux with the Flatpak versions of Dolphin and Wheel Wizard. The launching code did not have the assumption that the config folder would be configurable in the future.

Potentially related issue: #249

Summary by CodeRabbit

  • Bug Fixes
    • Optimized Flatpak integration with improved permission handling for Dolphin launcher support.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 4, 2026

📝 Walkthrough

Walkthrough

Modified FixFlatpakDolphinPermissions to attempt Flatpak document-export via portal access before falling back to read-only filesystem override for the RR launch JSON file path. The method now conditionally applies read-only permissions only when portal export fails.

Changes

Cohort / File(s) Summary
Flatpak Permission Logic
WheelWizard/Services/Launcher/Helpers/DolphinLaunchHelper.cs
Updated FixFlatpakDolphinPermissions to attempt portal export before applying read-only filesystem permission as fallback for RR launch JSON file path access.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A permission fix, so neat and wise,
First try the portal, what a surprise!
If export fails, fallback we go,
Read-only access—permission flow!
Flatpak permissions, now in the right place. 🚀

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description is brief but lacks detail on testing procedures and specific changes made, deviating from the provided template structure. Expand the description to include: (1) explicit 'Purpose of this PR' section, (2) detailed 'How to Test' steps, (3) comprehensive 'What Has Been Changed' section, and (4) complete the checklist before merging.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: attempting portal access fix for RR.json when the folder has changed, which aligns with the changeset's modification to DolphinLaunchHelper.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dolphin-rr-json-access

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@matellush matellush changed the base branch from main to dev April 4, 2026 17:36
@matellush matellush marked this pull request as draft April 4, 2026 17:52
@matellush matellush force-pushed the fix/dolphin-rr-json-access branch from 3ca9de9 to 2499a98 Compare April 4, 2026 18:04
@matellush matellush marked this pull request as ready for review April 4, 2026 18:14
@patchzyy patchzyy merged commit 05b7a48 into dev Apr 8, 2026
2 checks passed
@patchzyy patchzyy deleted the fix/dolphin-rr-json-access branch April 8, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants