fix: Add QT_QPA_PLATFORM environment variable#97
Merged
Conversation
DirkDoes
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
Expose this environment variable to non-Flatpak Dolphin executables on Linux to fix crashes on Wayland.
How to Test:
A machine with a recent KDE Plasma version on Wayland can be used along with a native
dolphin-emuinstallation to test that e.g. the Software Renderer backend works to launch Retro Rewind./proc/<pid>/environwithpidof thedolphin-emuprocess should show theQT_QPA_PLATFORM=xcbenvironment variable. I've tested this and it works.What Has Been Changed:
The Dolphin launcher will now add this environment variable where needed on Linux systems to the launched process.
Related Issue Link:
#95
Checklist before merging