Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 본 PR은 첨삭 상세 조회 API에서 강제되던 INTERNAL 포트폴리오 필터링 로직을 제거하는 것을 목적으로 합니다. 이 변경을 통해 외부 포트폴리오 첨삭 시 발생하던 예외 상황을 방지하고, 불필요한 의존성을 제거하여 코드의 복잡도를 낮추었습니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
- 서비스 로직이 줄어듦에 따라 파사드 대신 서비스를 직접 호출하도록 리팩토링함
There was a problem hiding this comment.
Pull request overview
Removes the INTERNAL-only filtering logic from the internal “correction detail” read path so AI-server driven correction flows can fetch the full set of portfolios/items (including externally sourced portfolios) without being filtered out.
Changes:
- Wire
GET /corrections/:correctionIdto callPortfolioCorrectionService.getInternalCorrectionDetaildirectly. - Remove
InternalCorrectionFacadeand its DI registration fromInternalModule.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/modules/internal/presentation/internal-correction.controller.ts |
Stops using the internal facade and directly fetches correction detail payload from PortfolioCorrectionService. |
src/modules/internal/internal.module.ts |
Removes InternalCorrectionFacade from module providers/imports. |
src/modules/internal/application/facades/internal-correction.facade.ts |
Deletes the facade that applied SourceType.INTERNAL filtering to portfolios/items in the internal correction detail response. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* fix: 첨삭 상세 조회에 대한 INTERNAL 필터 처리 제거 * refactor: 불필요한 계층구조 제거 - 서비스 로직이 줄어듦에 따라 파사드 대신 서비스를 직접 호출하도록 리팩토링함
Summary
첨삭 상세 조회에 대한 INTERNAL 필터 처리를 제거하여 외부 포트폴리오 첨삭 시 생길 수 있는 에러를 해결합니다.
Changes
Type of Change
해당하는 항목에 체크해주세요:
Target Environment
배포 대상 브랜치를 선택해주세요:
dev)main)Related Issues
관련 이슈를 연결해주세요:
Testing
테스트 방법을 작성해주세요:
Checklist
PR 생성 전 확인사항:
docs/development/CODE_STYLE.md)docs/development/GIT_CONVENTIONS.md)docs/development/NAMING_CONVENTIONS.md)pnpm run build)pnpm run lint)Screenshots (Optional)
UI 변경이 있다면 스크린샷을 첨부해주세요.
Additional Notes
리뷰어에게 전달할 추가 정보가 있다면 작성해주세요.