New portfolio page with styled components#36
Open
phenomenalCode wants to merge 20 commits intoTechnigo:mainfrom
Open
New portfolio page with styled components#36phenomenalCode wants to merge 20 commits intoTechnigo:mainfrom
phenomenalCode wants to merge 20 commits intoTechnigo:mainfrom
Conversation
Author
Closed
Contributor
|
Hi again, so this is the PR we should look at? And this is the Netlify link: Could you also share the Figma design you used and then I'll review 🥳 |
Author
|
I never did a figma design i told jennie (im sure it was her but i could be
wrong) and she said it would be okay
…On Tue, Aug 5, 2025 at 4:51 PM Matilda Brunemalm ***@***.***> wrote:
*HIPPIEKICK* left a comment (Technigo/js-project-portfolio#36)
<#36 (comment)>
Hi again, so this is the PR we should look at? And this is the Netlify
link:
https://portfolio-new-darius.netlify.app/?
Could you also share the Figma design you used and then I'll review 🥳
—
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKQ46H532VYBCA2T6YAMGWD3MDAHLAVCNFSM6AAAAACDALS5ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNJVGU2DSOBYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Since following a design is the main requirement for this project, I cannot approve this project as it is right now. I would recommend you just follow one of the designs we provided so that you don't need to create your own. Request a re-review when you're done. |
Author
|
it would be easier to just make an identical figma design than restyling
the the page
…On Thu, 21 Aug 2025 at 14:13, Matilda Brunemalm ***@***.***> wrote:
*HIPPIEKICK* left a comment (Technigo/js-project-portfolio#36)
<#36 (comment)>
Since following a design is the main requirement for this project, I
cannot approve this project as it is right now. I would recommend you just
follow one of the designs we provided so that you don't need to create your
own. Request a re-review when you're done.
—
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKQ46HZJA5OX36Q36D3Y45T3OWZVDAVCNFSM6AAAAACDALS5ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJQGM2DQMBSGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
Or actually what do I know. I will take a look at your designs.
…On Thu, 21 Aug 2025 at 14:15, D Carter ***@***.***> wrote:
it would be easier to just make an identical figma design than restyling
the the page
On Thu, 21 Aug 2025 at 14:13, Matilda Brunemalm ***@***.***>
wrote:
> *HIPPIEKICK* left a comment (Technigo/js-project-portfolio#36)
> <#36 (comment)>
>
> Since following a design is the main requirement for this project, I
> cannot approve this project as it is right now. I would recommend you just
> follow one of the designs we provided so that you don't need to create your
> own. Request a re-review when you're done.
>
> —
> Reply to this email directly, view it on GitHub
> <#36 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BKQ46HZJA5OX36Q36D3Y45T3OWZVDAVCNFSM6AAAAACDALS5ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJQGM2DQMBSGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Contributor
|
ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
netlify: https://darius-new-portfolio-school-version.netlify.app/