Skip to content

Leon Ekelund Portfolio hand-in#55

Open
LeonEkelund wants to merge 7 commits intoTechnigo:mainfrom
LeonEkelund:main
Open

Leon Ekelund Portfolio hand-in#55
LeonEkelund wants to merge 7 commits intoTechnigo:mainfrom
LeonEkelund:main

Conversation

@LeonEkelund
Copy link
Copy Markdown

Please include a link to your Figma design and a Netlify link.

Copy link
Copy Markdown

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</noscript>

<link rel="icon" type="image/x-icon" href="/src/assets/favicon.svg" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider removing the extra empty space here :)

Copy link
Copy Markdown

@artakjato artakjato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project is overall very well organized into separate components and it is easy to read. I had a few minor comments but nothing major to mention here.
Great job on adding you new projects!

import HeaderSection from './sections/HeaderSection';
import TechSection from './sections/TechSection';
import ProjectsSection from './sections/ProjectsSection';
// import ThoughtsSection from './sections/ThoughtsSection';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider removing commented out import from the final version

<Info>0709752924</Info>
<Info>leongudmundssonekelund@gmail.com</Info>

<Icons>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The social media contacts do not appear on the page as they are empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants