Open
Conversation
Vera-Sjunnesson
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
The result looks amazing! Well done! The code has a very clear structure - it's simple but effective. There are so many section, and it's impressive how much was done in such a short time.
Note:
It's not 100% responsive yet. In mobile and tablet view the images inProgram.js don't have a set size and are therefore wider than the <body>.
| <button type="submit">Start trial</button> | ||
| </div> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Very clear structure with .js and .css in the same folder
Comment on lines
+20
to
+32
| .program-images { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| .program-image { | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| width: 45%; | ||
| margin-bottom: 30px; | ||
| } |
There was a problem hiding this comment.
These images are not responsive in tablet and mobile. I think a specific width is needed to fix this.
Comment on lines
+25
to
+48
| <form> | ||
| <div className="form-group"> | ||
| <div className="name-group"> | ||
| <label htmlFor="firstname name">First name:</label> | ||
| <input type="text" id="firstname" name="firstname" required /> | ||
| </div> | ||
| <div className="name-group"> | ||
| <label htmlFor="surname">Surname:</label> | ||
| <input type="text" id="surname" name="surname" required /> | ||
| </div> | ||
| </div> | ||
| <div className="form-group"> | ||
| <label htmlFor="email">Email:</label> | ||
| <input type="email" id="email" name="email" required /> | ||
| </div> | ||
| <div className="form-group"> | ||
| <label htmlFor="password">Password:</label> | ||
| <input type="password" id="password" name="password" required /> | ||
| </div> | ||
| <div className="button-container-plan"> | ||
| <button className="create-account" type="submit">Create Account</button> | ||
| <p className="create-account-text">Already have an account? <a href="#">Login</a></p> | ||
| </div> | ||
| </form> |
There was a problem hiding this comment.
When there is time, it would make sense to make customized validation with error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.