Project Design Handover - Hannah Ek#41
Conversation
jonsjak
left a comment
jonsjak
left a comment
There was a problem hiding this comment.
Since I don't have the design, it's hard to know exactly what it's supposed to look like but everything looks nice and functioning in my opinion. Good use and reuse of styled components.
There are some minor issues with the image caroussels, they act differently when spinning and some of the images gets out of line. .At first I didn't get that the images move because there is no arrow or other indicator of it, but I guess that's how the design is supposed to look.
Overall a very good job! Good looking design and well executed in code. Kudos!
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link href="https://fonts.googleapis.com/css2?family=Libre+Baskerville:wght@700&display=swap" rel="stylesheet"> | ||
| <link href="https://fonts.googleapis.com/css2?family=Abril+Fatface&display=swap" rel="stylesheet"> | ||
| <meta property="og:title" content="Project Design Handover"> <!-- OG (open graph) tags are snippets of code that provide meta data about a web page, mainly to social media platforms (ex facebook, linkedin, instagram)--> |
| <Footer /> | ||
| </> | ||
| ); | ||
| } No newline at end of file |
There was a problem hiding this comment.
Nice App.js. Well structured and easy to follow!
| @@ -0,0 +1,12 @@ | |||
| import React from 'react'; | |||
|
|
|||
| const PopUpModal = () => { | |||
There was a problem hiding this comment.
What is this part? Can't find any popup.
2 participants
No description provided.