Skip to content

Only media bigger than 1600px #51

Open
SaraBat wants to merge 1 commit intoTechnigo:masterfrom
SaraBat:master
Open

Only media bigger than 1600px #51
SaraBat wants to merge 1 commit intoTechnigo:masterfrom
SaraBat:master

Conversation

@SaraBat
Copy link

@SaraBat SaraBat commented May 1, 2023

Page for media devices bigger than 1600px
https://lustrous-belekoy-c7ea01.netlify.app/

Copy link

@PerErikAndreas PerErikAndreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sara!
First of all great work with your site! And for anyone that reads this review, this site was made from a sketch in only 4 days(!). Especially great work with the BenefitsSction that contains a lot divs thats all styled with styled components. Good and clear nameing on the components too. Well done! Also nice that you put the styled-components in the bottom of the document. I might implement that way too.

I have not seen the design in Figma but (as you also wrote in the repositiry) the site works best in desktop mode and is sidescroll when going in to mobileview. I think it´s the Cards thats too wide. I will leave more single comments in the code document.

Great work!

)
}

export const HeroSection = styled.section`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great structure with the styled-components Sara! Nice work


export const Navbar = () => {
return (
<Navbardiv>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All styled-components makes it easy to read!

import React from 'react';
import styled from 'styled-components';
import Insagram from '../Images/Instagram.png';
import Facebook from '../Images/Facebook.png';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is really well structured Sara!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants