Maryyy_ux_project-happy-thoughts-api#513
Open
Maryyy-ux wants to merge 2 commits intoTechnigo:masterfrom
Open
Conversation
Author
HIPPIEKICK
requested changes
Jan 9, 2025
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Changes requested
- Use mongoose methods when you can
- Remove .env file
- Update frontend with the link to your own deployed API
otherwise - good job!
Contributor
There was a problem hiding this comment.
Now your method of uploading files is becoming a problem... Your env file should never be uploaded to GitHub, that's why it's included in the git ignore file. This wouldn't happen if you follow our instructions of committing files the "developer way"
Contributor
There was a problem hiding this comment.
Nice that you broke this out 👍
Comment on lines
+63
to
+69
| const thought = await Thought.findById(thoughtId); | ||
| if (!thought) { | ||
| return res.status(404).json({ error: 'Thought not found' }); | ||
| } | ||
| thought.hearts += 1; // Hearts increases//Incrementar el número de corazones | ||
| await thought.save(); | ||
| res.json(thought); |
Contributor
There was a problem hiding this comment.
Why not use findByIdAndUpdate for updating hearts directly instead of fetching, modifying, and saving? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(https://maryyy-ux-project-happy-thoughts-api.onrender.com/)