Open
Conversation
Joanna-Philips
suggested changes
Apr 1, 2023
There was a problem hiding this comment.
Excellent job on this week's project. :D
What went well:
- The code is well organised and easy to read.
-Stretch goals done well.
-The page is responsive, and functional.
What could be better:
-The if condition for the length of the new thought doesn't work fully - see comment in code.
As always, really nice work Nora. Keep it up! 🎉
| message: newThought | ||
| }) | ||
| } | ||
| if (newThought.length > 4) { |
There was a problem hiding this comment.
It seems like this if condition is not fully functional, because a new thought is still posted if the length = 4.
Author
There was a problem hiding this comment.
I think that shouldn't be possible because even without adding an if statement the post request blocks it if the text is under 5 characters. The if statement only adds the error msg.
| const handleFormSubmit = (event) => { | ||
| console.log(newThought) | ||
| event.preventDefault() | ||
| const options = { |
There was a problem hiding this comment.
Good idea storing the method in a variable.
| const Loading = () => { | ||
| return ( | ||
| <section> | ||
| <FadeLoader /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noras-happy-thoughts-project.netlify.app