Skip to content

Week 7 - Happy Thoughts by Daniel #442

Open
dannebrob wants to merge 18 commits intoTechnigo:masterfrom
dannebrob:master
Open

Week 7 - Happy Thoughts by Daniel #442
dannebrob wants to merge 18 commits intoTechnigo:masterfrom
dannebrob:master

Conversation

@dannebrob
Copy link

Copy link

@JosefinRobertsson JosefinRobertsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good naming of classnames and functions. Any deviations from the specified styling was deliberate choices you made so all good there. Code is orderly and easy to follow. You might want to add a little snippet to clear the textarea after posting. Keep up the good work!

<p>x{thought.hearts}</p>
</div>
<div className="time">
<p>{moment(thought.createdAt).fromNow()}</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got posted "in a few seconds" when I posted a thought, so this way of handling the post time seems to have some vulnerabilities. Unless you made some sort of time machine, which is awesome, and in that case: carry on

</label>
<button
type="submit"
disabled={newPost.length < 5 || newPost.length > 140}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart way of handling the allowed input length!

display: flex;
flex-wrap: wrap;
border: 2px solid black;
box-shadow: 10px 10px 5px 0px rgba(0, 0, 0, 0.75);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The softened box-shadow looks nice

Copy link

@JosefinRobertsson JosefinRobertsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good naming of classnames and functions. Any deviations from the specified styling was deliberate choices you made so all good there. Code is orderly and easy to follow. You might want to add a little snippet to clear the textarea after posting. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants